Refactor MSSQL scaler #6714
Open
Refactor MSSQL scaler #6714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickbrouwer
force-pushed
the
mssql-refactor
branch
7 times, most recently
from
b48a2e5 to
1fc3928
Compare
|
/run-e2e mssql |
SpiritZhou
reviewed
Apr 21, 2025
rickbrouwer
force-pushed
the
mssql-refactor
branch
6 times, most recently
from
ccc8fbf to
5cdc44b
Compare
JorTurFer
reviewed
Apr 21, 2025
|
/run-e2e mssql |
|
e2e test are failing because of an error: "error": "error establishing mssql connection: mssql: login error: Login failed for user ''."*** |
Yes, thanks. I will look into it asap. |
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
force-pushed
the
mssql-refactor
branch
from
ec75747 to
3b7c722
Compare
Fixed :) |
|
/run-e2e mssql |
JorTurFer
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the scaler to match the new metadata guidelines.
Checklist
Related: 5797